:D

Ok, it seems to be working now?! I think I'd set the switch up incorrectly :o No more syntax questions I promise :D

Shouldn't do, would just mean that your $_GET[] array has more stuff in it.

If you're switching on $_GET['section'] as poole suggested then should work?

What are the symptoms?

Hmmm, I'm still having problems with this.

I've set up a switch for the $section which seems to work fine until I add another variable to the string ie,
?section=email&action=send

That shouldnt really cause a problem should it?

quote:

---

Originally posted by Ian
Yes - you must must must not append .php to the end of some user input and call that a filename.

FAR safer to say -

if var == main then page == main.php
if var == gigs then page == gigs.php

Either a switch or if you're feeling nifty make an array of strings to test and and array of filenames, in the same order so they share array index.

Then you just foreach through that and set your page address variable out of your filename array.

Hope that is clear enough haha

---

Yes - you must must must not append .php to the end of some user input and call that a filename.

FAR safer to say -

if var == main then page == main.php
if var == gigs then page == gigs.php

Either a switch or if you're feeling nifty make an array of strings to test and and array of filenames, in the same order so they share array index.

Then you just foreach through that and set your page address variable out of your filename array.

Hope that is clear enough haha

The above is a crude but effective way of doing it, theres a better way to do it but its more complex to write and understand

[Edited on 10-07-2007 by drax]

Try this

code:
$page = $_GET["p"];





if (($page =="")) {include('pages/page1.php');





} else if($page == 'Page1') 		 { include('pages/page1.php');

} else if($page == 'Page2') 		 { include('pages/page2.php');

} else if($page == 'Page3') 		 { include('pages/page3.php');

} else if($page == 'Page4')		{ include('pages/page4.php');





} else {include('pages/error.php');

}

/code]





Your links would look like this..







code:
<a href="?p=Page1" title="Link to page 1">This is a link</a>

quote:

---

Originally posted by poole
BTW i'm not using the same method as yourself (taking any user input) for security reasons.

---

BTW i'm not using the same method as yourself (taking any user input) for security reasons.

quote:

---

Originally posted by MikeLamb
What you did would have worked in older versions of PHP..

---

code:


<?php

require_once('config.php');

require_once('opendb.php');

require_once('header.php');

// gets url.com/file.php?section=bleh

switch ($_GET['section']) {

case "main":

include_once('main.php');

break;

case "example":

include_once('example.php');

break;

default:

include_once('gigs.php);

}

require 'footer.php';

?>

What you did would have worked in older versions of PHP..

quote:

---

Originally posted by James
You've not done a get?

$section = $_GET['section'];

---

You've not done a get?

$section = $_GET['section'];

code:


<?php



if(!isset($section))

{

	$section="list_gigs";

}





$section .= ".php";



echo $section;



require 'config.php';

require 'opendb.php';

require 'header.php';

require $section;

require 'footer.php';



?>